Repository navigation
Feat: Move public and derivable values off the row and turn off features per build - #220
Merged
Merged
Conversation
IDC_DEV_TOOLS_INSPECT and IDC_DEV_TOOLS_CONSOLE are read from chrome/app/chrome_command_ids.h at each milestone's branch (150 to 159), so they are no longer row values. The runtime takes them by the build's milestone, and the row generator writes them from the same table for older runtimes instead of carrying them over unchecked.
A row that crosses a milestone no longer goes to review as a whole for its carried values. Each carried value that only one feature reads (split view, vertical tabs, the Sidebar, the app window, address suggestions, the developer colours, the frame colour) turns that feature off with the switch the runtime already obeys, and is cleared, so no value of the prior build reaches a browser. A value the runtime does not read in this row is written as zero. A value of the frame or the page area layout still stops the row. The row names its switched-off features, and the feature gate does not require their checks, so the rest of the row ships once its checks pass.
ui/views/view.h declares parent_, then children_, and bounds_ 0x30 bytes after parent_. Every row that recorded the two fields by hand agrees, and the view walk in reflect.rs finds the same pair at run time. The runtime now takes them from the layout's bounds offset, and the row generator writes them from it instead of carrying them over.
Both are DIPs Rivet chooses for its own layout, not values of the build, so a row keeps them from its prior row as settings instead of listing them as carried.
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of NFR-6 in the D16 order. A milestone change no longer sends a whole row to review because of carried values. Public command ids and a view's parent and children fields leave the row. Rivet's own choices become settings. A value that only one feature reads now turns that feature off for that build, with the runtime's existing switch.
Nothing was built, tested or run in this worktree. The owner builds on develop after the merge.
Commits
Feat: Take the developer bar commands from Chromium's public command ids(A).rivet/platform/windows/src/command_ids.rsholdsIDC_DEV_TOOLS_INSPECT(40023) andIDC_DEV_TOOLS_CONSOLE(40005). Both were read fromchrome/app/chrome_command_ids.hat branches 7871 to 8154 (Chromium 150 to 159). The runtime takes them by milestone (browsers::chromium::commands::dev_tools).DevModeno longer hasinspect/console. The generator writes them from the table, or 0 for an unread milestone, and does not carry them.Feat: Turn off only the features whose row values could not be read. See below.Feat: Take a view's parent and children fields from its bounds offset(B). Inui/views/view.h,parent_comes 0x30 beforebounds_, andchildren_comes right afterparent_. Every compiled row agrees with this (testnfr6_a_views_parent_and_children_are_not_row_values). Thereflect.rswalk finds the same pair at run time. The runtime takes both fromlayout.view_bounds_offset. The generator writes them from it (row_recipe::FOLLOWS).Feat: Keep Rivet's toolbar lead and top inset adjustment as settings(D).Per feature switch-off (NFR-6)
rivet/platform/windows/src/row_features.rsmaps each row value to the feature that alone reads it. It reuses the switches the runtime already obeys:split.supported = falsesplit.*split,split-*vertical.supported = falseupdate_collapse_action,browser_offset,mode_offset,width_offsetside_panel.supported = falsecolor_source,source_in_widget,entry_count,extension_entry,features_*,hidden_entries, and the layout fields only the Sidebar reads (side_panel,side_panel_animation,contents_outline,vertical_tabs, set to ABSENT)sidebar,sidebar-*,fullscreen-sidebarapp_window = nullapp_window.*mini-*,tab-movesomnibox = nullomnibox.*address-suggest,security-chiptoolbar.dev.colours = []dev-rowlayout.provider_verified = falseframe_ids,caption_ink_idsWhen the generator must check carried values (a milestone changed, or values were read from the prior build next to the new one),
settle_carrieddoes the following:tabs.tab_collectionandtabs.tab_contentsare unread whiletab_atis recorded. The window feature values are unread whilevertical.window_featureis absent.switched_off, and the report underswitched_off.chrome-builds gate <results> <browser> <row.json>does not require the checks of a switched-off feature, and prints a note for each. The workflow passes the row. Every other check must still pass. A draft PR body now also lists the switched-off features.I checked every reader of the switched values. Split view hooks install only when
checked(). Sidebar colours and page area reads run only when the Sidebar is checked and the rail is open. The app layout slot is read only with theomniboxpart.Classification of carried values
Classes: A is a public stable surface, B is name or source-layout reflection, C needs a build recipe (D16 point 3), and D is a Rivet setting.
Union of the three reports: 102 carried paths (list items counted one by one). A 2, B 19, C 79, D 2.
app_window.bounds_changed_slotapp_window.browser_typeapp_window.destructor_slotapp_window.view_childrenviews::View::children_, right afterparent_inui/views/view.happ_window.view_parentviews::View::parent_, 0x30 beforebounds_inui/views/view.h; thereflect.rswalk finds the same pairlayout.browser_window_in_viewlayout.caption_container_offsetBrowserFrameViewWinchildBrowserCaptionButtonContainerby class namelayout.caption_ink_idslayout.caption_ink_ids[0]layout.caption_ink_ids[1]layout.caption_ink_ids[2]layout.frame_browser_window_offsetBrowserViewlayout.frame_idslayout.frame_ids[0]layout.frame_ids[1]layout.frame_ids[3]layout.frame_ids[4]layout.frame_ids[5]layout.top_inset_adjustlayout.view_bounds_offsetviews::Viewmetadata propertyBoundsomnibox.app_layout_slotomnibox.controller_published_resultomnibox.controller_sizeomnibox.input_omit_asynchronousomnibox.input_prevent_inlineomnibox.input_sizeomnibox.match_contentsomnibox.match_descriptionomnibox.match_destinationomnibox.match_sizeomnibox.provider_client_sizeomnibox.scheme_classifier_sizeside_panel.color_sourceside_panel.contents_containerMultiContentsView/ContentsContainerViewby class nameside_panel.contents_outlineside_panel.entry_countside_panel.extension_entryside_panel.features_coordinatorside_panel.features_offsetside_panel.hidden_entries[0]side_panel.host_viewui::metadataclass isBrowserViewside_panel.page_areabrowser_view_layout.h)side_panel.side_panelSidePanelby class nameside_panel.side_panel_animationside_panel.source_in_widgetside_panel.toolbarToolbarViewby class nameside_panel.vertical_tabsVerticalTabStripRegionViewby class namesplit.active_membersplit.container_count_membersplit.container_delegate_offsetsplit.containers_memberMultiContentsViewvector ofContentsContainerViewby class name (multi_contents_view.h)split.flex_layout_hostsplit.layout_delegate_offsetsplit.mini_toolbar_memberContentsContainerViewchildMultiContentsViewMiniToolbarby class namesplit.outline_memberContentsContainerViewoutline child by class namesplit.set_border_slotsplit.set_visible_slotviews::Viewmetadata propertyVisiblesplit.split_insets_membersplit.view_sizeviews::Viewmetadata propertyBounds(size)tabs.tab_collectiontabs.tab_contentstoolbar.dev.colours[0][0]toolbar.dev.colours[10][0]toolbar.dev.colours[11][0]toolbar.dev.colours[12][0]toolbar.dev.colours[13][0]toolbar.dev.colours[14][0]toolbar.dev.colours[15][0]toolbar.dev.colours[16][0]toolbar.dev.colours[17][0]toolbar.dev.colours[18][0]toolbar.dev.colours[19][0]toolbar.dev.colours[1][0]toolbar.dev.colours[20][0]toolbar.dev.colours[21][0]toolbar.dev.colours[22][0]toolbar.dev.colours[23][0]toolbar.dev.colours[24][0]toolbar.dev.colours[25][0]toolbar.dev.colours[26][0]toolbar.dev.colours[27][0]toolbar.dev.colours[2][0]toolbar.dev.colours[3][0]toolbar.dev.colours[4][0]toolbar.dev.colours[5][0]toolbar.dev.colours[6][0]toolbar.dev.colours[7][0]toolbar.dev.colours[8][0]toolbar.dev.colours[9][0]toolbar.dev.consoleIDC_DEV_TOOLS_CONSOLE,chrome/app/chrome_command_ids.htoolbar.dev.inspectIDC_DEV_TOOLS_INSPECT,chrome/app/chrome_command_ids.htoolbar.get_widget_slotvertical.browser_offsetvertical.mode_offsetvertical.toolbar_in_viewvertical.toolbar_leadingvertical.update_collapse_actionvertical.width_offsetvertical.window_feature_callersvertical.window_feature_callers[0]vertical.window_feature_callers[1]vertical.window_feature_tab_striplayout.browser_window_in_view,layout.caption_container_offset,layout.frame_browser_window_offset,layout.view_bounds_offset,side_panel.contents_container,side_panel.host_view,side_panel.page_area,side_panel.toolbar,toolbar.get_widget_slot). Features off: address suggestions, app window, developer colours, frame colour, sidebar, split view, vertical tabs. Zero, not read by this build: 5.layout.browser_window_in_view,layout.caption_container_offset,layout.frame_browser_window_offset,layout.view_bounds_offset,side_panel.contents_container,side_panel.host_view,side_panel.page_area,side_panel.toolbar,toolbar.get_widget_slot). Features off: address suggestions, app window, developer colours, frame colour, sidebar, split view, vertical tabs. Zero, not read by this build: 5.layout.frame_browser_window_offset,side_panel.contents_container,side_panel.host_view,side_panel.page_area,toolbar.get_widget_slot). Features off: address suggestions, app window, developer colours, frame colour, sidebar, split view, vertical tabs. Zero, not read by this build: 6.Not done here
layout.view_bounds_offset,layout.frame_browser_window_offset,layout.browser_window_in_view,layout.caption_container_offset,side_panel.host_view,page_area,contents_container,toolbar, andtoolbar.get_widget_slot. Most are B (see the table), but their reflection paths are not built yet. Those paths need runtime work and a browser run per browser, which this worktree may not do. Next step: find these layout fields by theui::metadataclass name of the view each one points to, the same wayreflect.rsfindsBrowserView.port),read_carrieddoes not run, because no prior module is fetched. So a milestone change turns off every feature in the table. On the no-PDB path (find), values read from the instructions keep their features on. Fetching the prior module on the PDB path would keep more features on.0x0forvertical.update_collapse_actionwhere other rows write the absent marker. So that address shows up as a carried number. It is in vertical tabs, which is off on Edge anyway.🤖 Generated with Claude Code